Skip to content
This repository was archived by the owner on Jan 5, 2024. It is now read-only.

Protect against "socket is None" in iostream.close() with try/catch - #417

Merged
yurishkuro merged 2 commits into
masterfrom
fix-socket-close
Jul 7, 2016
Merged

yurishkuro merged 2 commits into
masterfrom
fix-socket-close

Conversation

@yurishkuro

Copy link
Copy Markdown
Contributor

Temporary fix for #416

@blampe

blampe commented Jul 7, 2016

Copy link
Copy Markdown
Contributor

+@abhinav

@coveralls

coveralls commented Jul 7, 2016 •

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.07%) to 93.584% when pulling dd25802 on fix-socket-close into f9651f8 on master.

@abhinav

abhinav commented Jul 7, 2016

Copy link
Copy Markdown
Contributor

:shipit:

@abhinav

abhinav commented Jul 7, 2016

Copy link
Copy Markdown
Contributor

Ignore the coveralls failure. We need to adjust the threshold.

@yurishkuro
yurishkuro merged commit db8f2de into master Jul 7, 2016
@abhinav
abhinav deleted the fix-socket-close branch July 7, 2016 20:09
@HelloGrayson

Copy link
Copy Markdown
Contributor

ty sir

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants